sebse/factorio-signal-exporter
1
0
Fork 0
Code Issues 25 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

[#1] B1: MAX_SERIES overrides user series_limit #26

Open
sebse wants to merge 1 commits from 1-max-series-parameter into main
pull from: 1-max-series-parameter
merge into: sebse:main
Conversation 0 Commits 1 Files Changed 2 +3 -4
sebse commented 2026-06-05 10:53:03 +00:00
Owner
Copy Link

File: web/components/ChartCard/seriesData.ts\n\nReplaced hardcoded MAX_SERIES = 80 with seriesLimit parameter defaulting to 80. Updated SignalsChart.tsx to pass config.series_limit.\n\nFixes #1

**File:** web/components/ChartCard/seriesData.ts\n\nReplaced hardcoded MAX_SERIES = 80 with seriesLimit parameter defaulting to 80. Updated SignalsChart.tsx to pass config.series_limit.\n\nFixes #1
sebse added the bug label 2026-06-05 10:53:03 +00:00
sebse added 1 commit 2026-06-05 10:53:04 +00:00
fix: pass config.series_limit to buildSeriesData instead of hardcoded 80 8b5d4ee6a5
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 1-max-series-parameter:1-max-series-parameter
git checkout 1-max-series-parameter
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 code-smell
Code quality or maintainability issue
 enhancement
New feature or extension idea
 low-hanging-fruit
Easy to fix, high impact
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sebse
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sebse/factorio-signal-exporter#26
Delete Branch "1-max-series-parameter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?