sebse/factorio-signal-exporter
1
0
Fork 0
Code Issues 25 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

B1: Hardcoded MAX_SERIES overrides user series_limit #1

New Issue
Open
opened 2026-06-05 10:21:38 +00:00 by sebse · 0 comments
sebse commented 2026-06-05 10:21:38 +00:00
Owner
Copy Link

Bug

File: web/components/ChartCard/seriesData.ts:3

buildSeriesData() hardcodes MAX_SERIES = 80 but chart editor allows series_limit up to 200. API returns the user-requested limit, then frontend silently truncates to 80.

Impact

User configures 150 series → chart shows only 80. No warning.

Fix

Replace constant with a parameter from config.series_limit.

Code reference

const MAX_SERIES = 80;

API already respects user limit. buildSeriesData needs to accept and use it.

## Bug **File:** `web/components/ChartCard/seriesData.ts:3` `buildSeriesData()` hardcodes `MAX_SERIES = 80` but chart editor allows `series_limit` up to 200. API returns the user-requested limit, then frontend silently truncates to 80. ### Impact User configures 150 series → chart shows only 80. No warning. ### Fix Replace constant with a parameter from `config.series_limit`. ### Code reference ```ts const MAX_SERIES = 80; ``` API already respects user limit. `buildSeriesData` needs to accept and use it.
sebse added the bug label 2026-06-05 10:21:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is broken
 code-smell
Code quality or maintainability issue
 enhancement
New feature or extension idea
 low-hanging-fruit
Easy to fix, high impact
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sebse
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sebse/factorio-signal-exporter#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?