sebse/factorio-signal-exporter
1
0
Fork 0
Code Issues 25 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

[#6] C1: Regenerate package-lock.json + add PR build workflow #31

Open
sebse wants to merge 1 commits from fix-lockfile-and-pr-workflow into main
pull from: fix-lockfile-and-pr-workflow
merge into: sebse:main
Conversation 0 Commits 1 Files Changed 2 +39
sebse commented 2026-06-05 11:34:06 +00:00
Owner
Copy Link

Lockfile sync: npm install regenerated package-lock.json — adds the missing @emnapi/runtime@1.10.0 peer dependency that caused npm ci to fail during Docker builds.

PR workflow: .gitea/workflows/pr.yml builds both app and migrate Docker images on every pull_request to main, but never pushes images, versions, or deploys Helm — visibility without side effects.

Files changed

  • .gitea/workflows/pr.yml — new PR workflow (build only, no push)
  • web/package-lock.json — regenerated, adds peer: true for @emnapi/core

Checklist

  • Lockfile regenerated with npm install (verified: npm ci now passes)
  • PR workflow builds app + migrate images
  • No push, version, or Helm deployment on PR
**Lockfile sync:** `npm install` regenerated `package-lock.json` — adds the missing `@emnapi/runtime@1.10.0` peer dependency that caused `npm ci` to fail during Docker builds. **PR workflow:** `.gitea/workflows/pr.yml` builds both `app` and `migrate` Docker images on every `pull_request` to `main`, but never pushes images, versions, or deploys Helm — visibility without side effects. ## Files changed - `.gitea/workflows/pr.yml` — new PR workflow (build only, no push) - `web/package-lock.json` — regenerated, adds `peer: true` for `@emnapi/core` ## Checklist - [x] Lockfile regenerated with `npm install` (verified: `npm ci` now passes) - [x] PR workflow builds app + migrate images - [x] No push, version, or Helm deployment on PR
sebse added the bug label 2026-06-05 11:34:06 +00:00
sebse added 1 commit 2026-06-05 11:34:07 +00:00
fix: sync lock file and add PR build workflow
Some checks failed
PR Build / build (pull_request) Failing after 57s
Details
22fa5d4aa2
Some checks failed
PR Build / build (pull_request) Failing after 57s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix-lockfile-and-pr-workflow:fix-lockfile-and-pr-workflow
git checkout fix-lockfile-and-pr-workflow
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 code-smell
Code quality or maintainability issue
 enhancement
New feature or extension idea
 low-hanging-fruit
Easy to fix, high impact
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sebse
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sebse/factorio-signal-exporter#31
Delete Branch "fix-lockfile-and-pr-workflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?