sebse/factorio-signal-exporter
1
0
Fork 0
Code Issues 25 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

S5: Redundant .env gitignore patterns #10

New Issue
Open
opened 2026-06-05 10:22:09 +00:00 by sebse · 0 comments
sebse commented 2026-06-05 10:22:09 +00:00
Owner
Copy Link

Code Smell

File: web/.gitignore and .gitignore

Root .gitignore: .env
Web .gitignore: .env*

The web pattern .env* matches .env.local, .env.production, .env.staging etc. The root .gitignore already applies recursively to subdirectories. The web pattern is stricter but duplicative.

Minor

No functional impact — both patterns work correctly. Just redundant config.

Suggestion

Remove .env* from web .gitignore since root .gitignore already covers .env. Or keep both for explicitness — very low priority.

## Code Smell **File:** `web/.gitignore` and `.gitignore` Root `.gitignore`: `.env` Web `.gitignore`: `.env*` The web pattern `.env*` matches `.env.local`, `.env.production`, `.env.staging` etc. The root `.gitignore` already applies recursively to subdirectories. The web pattern is stricter but duplicative. ### Minor No functional impact — both patterns work correctly. Just redundant config. ### Suggestion Remove `.env*` from web `.gitignore` since root `.gitignore` already covers `.env`. Or keep both for explicitness — very low priority.
sebse added the code-smell label 2026-06-05 10:22:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is broken
 code-smell
Code quality or maintainability issue
 enhancement
New feature or extension idea
 low-hanging-fruit
Easy to fix, high impact
No Label code-smell
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sebse
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sebse/factorio-signal-exporter#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?