From 023a90ec4f49613093c194b30b98f59e961b507c Mon Sep 17 00:00:00 2001 From: Caesar2011 Date: Sat, 14 Jul 2018 00:23:28 +0200 Subject: [PATCH] Removed unused TODOs and warnings in fragments-package --- .../fuplanner/fragments/ModulesAdapter.java | 3 +-- .../fuplanner/fragments/ModulesFragment.java | 17 ----------------- .../fuplanner/fragments/ScheduleFragment.java | 17 +---------------- .../fragments/moddetails/ModDetailAdapter.java | 4 +--- .../moddetails/ModDetailAnnounceFragment.java | 7 ------- .../moddetails/ModDetailAssignmentFragment.java | 7 ------- .../moddetails/ModDetailEventAdapter.java | 4 +--- .../moddetails/ModDetailEventFragment.java | 4 ---- .../fragments/moddetails/ModDetailFragment.java | 2 -- .../moddetails/ModDetailGradebookAdapter.java | 4 +--- .../moddetails/ModDetailGradebookFragment.java | 4 ---- .../moddetails/ModDetailOverviewAdapter.java | 3 +-- .../moddetails/ModDetailOverviewFragment.java | 4 ---- 13 files changed, 6 insertions(+), 74 deletions(-) diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/ModulesAdapter.java b/app/src/main/java/de/sebse/fuplanner/fragments/ModulesAdapter.java index 4ead049..5bbcdc6 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/ModulesAdapter.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/ModulesAdapter.java @@ -14,14 +14,13 @@ import de.sebse.fuplanner.tools.ui.ItemViewHolder; /** * {@link RecyclerView.Adapter} that can display a {@link Modules.Module} and makes a call to the * specified {@link OnModulesFragmentInteractionListener}. - * TODO: Replace the implementation with code for your data type. */ public class ModulesAdapter extends RecyclerView.Adapter { private Modules mValues; private final OnModulesFragmentInteractionListener mListener; - public ModulesAdapter(OnModulesFragmentInteractionListener listener) { + ModulesAdapter(OnModulesFragmentInteractionListener listener) { mValues = null; mListener = listener; } diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/ModulesFragment.java b/app/src/main/java/de/sebse/fuplanner/fragments/ModulesFragment.java index 0a6049f..edca8af 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/ModulesFragment.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/ModulesFragment.java @@ -24,10 +24,6 @@ import de.sebse.fuplanner.tools.logging.Logger; * interface. */ public class ModulesFragment extends Fragment { - - // TODO: Customize parameter argument names - //private static final String ARG_COLUMN_COUNT = "column-count"; - // TODO: Customize parameters private OnModulesFragmentInteractionListener mListener; private Logger log = new Logger(this); private ModulesAdapter adapter; @@ -40,8 +36,6 @@ public class ModulesFragment extends Fragment { public ModulesFragment() { } - // TODO: Customize parameter initialization - @SuppressWarnings("unused") public static ModulesFragment newInstance() { ModulesFragment fragment = new ModulesFragment(); Bundle args = new Bundle(); @@ -107,18 +101,7 @@ public class ModulesFragment extends Fragment { mListener = null; } - /** - * This interface must be implemented by activities that contain this - * fragment to allow an interaction in this fragment to be communicated - * to the activity and potentially other fragments contained in that - * activity. - *

- * See the Android Training lesson Communicating with Other Fragments for more information. - */ public interface OnModulesFragmentInteractionListener { - // TODO: Update argument type and name void onModulesFragmentInteraction(int item); } } diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/ScheduleFragment.java b/app/src/main/java/de/sebse/fuplanner/fragments/ScheduleFragment.java index 9b76717..359d45e 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/ScheduleFragment.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/ScheduleFragment.java @@ -26,14 +26,11 @@ import de.sebse.fuplanner.tools.ui.weekview.WeekViewEvent; /** * A simple {@link Fragment} subclass. * Activities that contain this fragment must implement the - * {@link ScheduleFragment.OnFragmentInteractionListener} interface + * {@link ScheduleFragment.OnScheduleFragmentInteractionListener} interface * to handle interaction events. * Use the {@link ScheduleFragment#newInstance} factory method to * create an instance of this fragment. * - * TODO Reduce day range to 6-20h as in https://stackoverflow.com/questions/35944431/filter-specific-range-of-hours-to-show-in-alamkanak-android-week-view - * - * TODO Scroll week wise (snap) */ public class ScheduleFragment extends Fragment implements MonthLoader.MonthChangeListener, WeekView.ScrollListener { private OnScheduleFragmentInteractionListener mListener; @@ -76,7 +73,6 @@ public class ScheduleFragment extends Fragment implements MonthLoader.MonthChang mWeekView.notifyDatasetChanged(); } } - }, error1 -> log.e(error1)); } }, error -> log.e(error)); @@ -146,18 +142,7 @@ public class ScheduleFragment extends Fragment implements MonthLoader.MonthChang mListener.onScheduleFragmentInteraction(newFirstVisibleDay, newLastVisibleDay); } - /** - * This interface must be implemented by activities that contain this - * fragment to allow an interaction in this fragment to be communicated - * to the activity and potentially other fragments contained in that - * activity. - *

- * See the Android Training lesson Communicating with Other Fragments for more information. - */ public interface OnScheduleFragmentInteractionListener { - // TODO: Update argument type and name void onScheduleFragmentInteraction(Calendar firstVisibleDate, Calendar lastVisibleDay); } } diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAdapter.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAdapter.java index 6217d68..c4c62ea 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAdapter.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAdapter.java @@ -6,14 +6,12 @@ import android.support.v4.app.FragmentManager; import android.support.v4.app.FragmentStatePagerAdapter; import de.sebse.fuplanner.R; -import de.sebse.fuplanner.tools.logging.Logger; class ModDetailAdapter extends FragmentStatePagerAdapter { private final int mItemPos; private final Context mContext; - private Logger log = new Logger(this); - public ModDetailAdapter(FragmentManager fm, int itemPosition, Context context) { + ModDetailAdapter(FragmentManager fm, int itemPosition, Context context) { super(fm); this.mContext = context; this.mItemPos = itemPosition; diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAnnounceFragment.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAnnounceFragment.java index a41a0ad..1a72af1 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAnnounceFragment.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAnnounceFragment.java @@ -1,7 +1,6 @@ package de.sebse.fuplanner.fragments.moddetails; -import android.content.Context; import android.os.Bundle; import android.support.annotation.NonNull; import android.support.v4.app.Fragment; @@ -23,11 +22,8 @@ import de.sebse.fuplanner.tools.logging.Logger; * create an instance of this fragment. */ public class ModDetailAnnounceFragment extends Fragment { - // TODO: Rename parameter arguments, choose names that match - // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER private static final String ARG_POSITION = "itemPosition"; - // TODO: Rename and change types of parameters private int mItemPos; private Logger log = new Logger(this); private ModDetailAnnounceAdapter adapter; @@ -45,7 +41,6 @@ public class ModDetailAnnounceFragment extends Fragment { * @param itemPosition Item position in module list. * @return A new instance of fragment ModDetailAnnounceFragment. */ - // TODO: Rename and change types and number of parameters public static ModDetailAnnounceFragment newInstance(int itemPosition) { ModDetailAnnounceFragment fragment = new ModDetailAnnounceFragment(); Bundle args = new Bundle(); @@ -68,9 +63,7 @@ public class ModDetailAnnounceFragment extends Fragment { // Inflate the layout for this fragment View view = inflater.inflate(R.layout.fragment_expandable_list_view, container, false); // Set the adapter - Context context = view.getContext(); ExpandableListView expandableListView = view.findViewById(R.id.list); - //expandableListView.setLayoutManager(new LinearLayoutManager(context)); adapter = new ModDetailAnnounceAdapter(); expandableListView.setAdapter(adapter); diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAssignmentFragment.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAssignmentFragment.java index 48005cc..f0d2a51 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAssignmentFragment.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailAssignmentFragment.java @@ -1,7 +1,6 @@ package de.sebse.fuplanner.fragments.moddetails; -import android.content.Context; import android.os.Bundle; import android.support.annotation.NonNull; import android.support.v4.app.Fragment; @@ -23,11 +22,8 @@ import de.sebse.fuplanner.tools.logging.Logger; * create an instance of this fragment. */ public class ModDetailAssignmentFragment extends Fragment { - // TODO: Rename parameter arguments, choose names that match - // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER private static final String ARG_POSITION = "itemPosition"; - // TODO: Rename and change types of parameters private int mItemPos; private Logger log = new Logger(this); private ModDetailAssignmentAdapter adapter; @@ -45,7 +41,6 @@ public class ModDetailAssignmentFragment extends Fragment { * @param itemPosition Item position in module list. * @return A new instance of fragment ModDetailAnnounceFragment. */ - // TODO: Rename and change types and number of parameters public static ModDetailAssignmentFragment newInstance(int itemPosition) { ModDetailAssignmentFragment fragment = new ModDetailAssignmentFragment(); Bundle args = new Bundle(); @@ -68,9 +63,7 @@ public class ModDetailAssignmentFragment extends Fragment { // Inflate the layout for this fragment View view = inflater.inflate(R.layout.fragment_expandable_list_view, container, false); // Set the adapter - Context context = view.getContext(); ExpandableListView expandableListView = view.findViewById(R.id.list); - //expandableListView.setLayoutManager(new LinearLayoutManager(context)); adapter = new ModDetailAssignmentAdapter(); expandableListView.setAdapter(adapter); diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailEventAdapter.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailEventAdapter.java index 17aba5c..b64934f 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailEventAdapter.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailEventAdapter.java @@ -31,10 +31,8 @@ public class ModDetailEventAdapter extends RecyclerView.Adapter> mPositionalData; - private Logger log = new Logger(this); - //private final ModulesFragment.OnModulesFragmentInteractionListener mListener; - public ModDetailEventAdapter(/*ModulesFragment.OnModulesFragmentInteractionListener listener*/) { + ModDetailEventAdapter() { mValue = null; mPositionalData = new ArrayList<>(); //mListener = listener; diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailEventFragment.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailEventFragment.java index 258ff4c..95ff906 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailEventFragment.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailEventFragment.java @@ -24,11 +24,8 @@ import de.sebse.fuplanner.tools.logging.Logger; * create an instance of this fragment. */ public class ModDetailEventFragment extends Fragment { - // TODO: Rename parameter arguments, choose names that match - // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER private static final String ARG_POSITION = "itemPosition"; - // TODO: Rename and change types of parameters private int mItemPos; private Logger log = new Logger(this); private ModDetailEventAdapter adapter; @@ -46,7 +43,6 @@ public class ModDetailEventFragment extends Fragment { * @param itemPosition Item position in module list. * @return A new instance of fragment ModDetailAnnounceFragment. */ - // TODO: Rename and change types and number of parameters public static ModDetailEventFragment newInstance(int itemPosition) { ModDetailEventFragment fragment = new ModDetailEventFragment(); Bundle args = new Bundle(); diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailFragment.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailFragment.java index 658bd04..955257b 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailFragment.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailFragment.java @@ -21,8 +21,6 @@ import de.sebse.fuplanner.R; * create an instance of this fragment. */ public class ModDetailFragment extends Fragment { - // TODO: Rename parameter arguments, choose names that match - // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER private static final String ARG_POSITION = "itemPosition"; // Parameters diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailGradebookAdapter.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailGradebookAdapter.java index 2860f15..e7f619c 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailGradebookAdapter.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailGradebookAdapter.java @@ -25,10 +25,8 @@ public class ModDetailGradebookAdapter extends RecyclerView.Adapter> mPositionalData; - private Logger log = new Logger(this); - //private final ModulesFragment.OnModulesFragmentInteractionListener mListener; - public ModDetailGradebookAdapter(/*ModulesFragment.OnModulesFragmentInteractionListener listener*/) { + ModDetailGradebookAdapter() { mValue = null; mPositionalData = new ArrayList<>(); //mListener = listener; diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailGradebookFragment.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailGradebookFragment.java index 0f5f5c3..64bc999 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailGradebookFragment.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailGradebookFragment.java @@ -24,11 +24,8 @@ import de.sebse.fuplanner.tools.logging.Logger; * create an instance of this fragment. */ public class ModDetailGradebookFragment extends Fragment { - // TODO: Rename parameter arguments, choose names that match - // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER private static final String ARG_POSITION = "itemPosition"; - // TODO: Rename and change types of parameters private int mItemPos; private Logger log = new Logger(this); private ModDetailGradebookAdapter adapter; @@ -46,7 +43,6 @@ public class ModDetailGradebookFragment extends Fragment { * @param itemPosition Item position in module list. * @return A new instance of fragment ModDetailAnnounceFragment. */ - // TODO: Rename and change types and number of parameters public static ModDetailGradebookFragment newInstance(int itemPosition) { ModDetailGradebookFragment fragment = new ModDetailGradebookFragment(); Bundle args = new Bundle(); diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailOverviewAdapter.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailOverviewAdapter.java index 2a242d6..5206d2b 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailOverviewAdapter.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailOverviewAdapter.java @@ -38,9 +38,8 @@ public class ModDetailOverviewAdapter extends RecyclerView.Adapter> mPositionalData; private Logger log = new Logger(this); - //private final ModulesFragment.OnModulesFragmentInteractionListener mListener; - public ModDetailOverviewAdapter(/*ModulesFragment.OnModulesFragmentInteractionListener listener*/) { + ModDetailOverviewAdapter() { mValue = null; mPositionalData = new ArrayList<>(); //mListener = listener; diff --git a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailOverviewFragment.java b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailOverviewFragment.java index f0da306..6b64b5c 100644 --- a/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailOverviewFragment.java +++ b/app/src/main/java/de/sebse/fuplanner/fragments/moddetails/ModDetailOverviewFragment.java @@ -24,11 +24,8 @@ import de.sebse.fuplanner.tools.logging.Logger; * create an instance of this fragment. */ public class ModDetailOverviewFragment extends Fragment { - // TODO: Rename parameter arguments, choose names that match - // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER private static final String ARG_POSITION = "itemPosition"; - // TODO: Rename and change types of parameters private int mItemPos; private Logger log = new Logger(this); private ModDetailOverviewAdapter adapter; @@ -46,7 +43,6 @@ public class ModDetailOverviewFragment extends Fragment { * @param itemPosition Item position in module list. * @return A new instance of fragment ModDetailOverviewFragment. */ - // TODO: Rename and change types and number of parameters public static ModDetailOverviewFragment newInstance(int itemPosition) { ModDetailOverviewFragment fragment = new ModDetailOverviewFragment(); Bundle args = new Bundle();